fix(v9/nuxt): Do not drop parametrized routes (#17357) #17359
Merged
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just found out Nuxt is dropping spans for catch-all routes. related to #16843 (as we have parametrized routes since then)
Lms24
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Ah I see, this is because .*)* in routes would test positive for path.extname? I wonder if we can make the file name check more robust instead. Not sure if the regex works well enough. Like for example check that it only contains alphanumeric values? Not sure if this is any better though, so happy to go with this as well for now.
Yes exactly! theoretically, it would be also possible to put the regex just on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found out Nuxt is dropping spans for catch-all routes.
related to #16843 (as we have parametrized routes since then)
backport of #17357